Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc comments for public APIs (Part 1) #55

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Add doc comments for public APIs (Part 1) #55

merged 3 commits into from
Sep 16, 2020

Conversation

kateinoigakukun
Copy link
Member

No description provided.

MaxDesiatov
MaxDesiatov approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thank you so much 👏 Just a couple of suggestions

kateinoigakukun and others added 2 commits September 16, 2020 20:19
@kateinoigakukun @MaxDesiatov
Update Sources/JavaScriptKit/FundamentalObjects/JSFunction.swift
26bc9d8 
Co-authored-by: Max Desiatov <max@desiatov.com>
@kateinoigakukun @MaxDesiatov
Update Sources/JavaScriptKit/FundamentalObjects/JSObject.swift
5f2eac9 
Co-authored-by: Max Desiatov <max@desiatov.com>
@kateinoigakukun
Copy link
Member Author

Thanks for wording suggestions 😄

@kateinoigakukun kateinoigakukun merged commit 2eade6f into master Sep 16, 2020
@kateinoigakukun kateinoigakukun deleted the add-doc-comments branch September 16, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov