Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSValue ExpressibleByNilLiteral #59

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Make JSValue ExpressibleByNilLiteral #59

merged 1 commit into from
Sep 16, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Sep 16, 2020

I have nil produce .null now but should it produce .undefined instead maybe? This is the last thing needed to get DOMKit building without AnyJSValueConvertible.

@j-f1 j-f1 mentioned this pull request Sep 16, 2020
Merged
MaxDesiatov
MaxDesiatov approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .null is appropriate here, .undefined corresponds more closely to ()/Void in my opinion.

@kateinoigakukun kateinoigakukun merged commit 8cdc2d1 into master Sep 16, 2020
@kateinoigakukun kateinoigakukun deleted the jsvalue-nil branch September 16, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @MaxDesiatov @kateinoigakukun