Remove payload2 from value bridging interface #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
minimize-payload
branch
from
dfbf282
to
2ba20d2
Compare
MaxDesiatov
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
This seems legit as the tests pass, but could we have a doc comment somewhere that clarifies the purpose, the number, and the types of payloads? I was going to provide a write up on JavaScriptKit internals, would be very interested to know more in details, if possible 🙏
j-f1
reviewed
Sep 18, 2020
j-f1
approved these changes
Sep 19, 2020
|
Thanks a lot for the diagrams! Happy for this to be merged, and maybe if you folks manage to review #62, it would be a good 0.7.0 release? 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #63