Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 4 perf tests instead of 2 #80

Merged
merged 7 commits into from
Sep 25, 2020
Merged

Run 4 perf tests instead of 2 #80

merged 7 commits into from
Sep 25, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Sep 25, 2020

It looks like the perf test script is running in ~2m before this change, which leaves plenty of time to gather more samples to hopefully smooth out the results so perf changes can be better caught.

I changed it to run the perf tests four times, with 2 in parallel at once. The constants can be easily changed if we find it’s still not stable enough.

@github-actions
Copy link

github-actions bot commented Sep 25, 2020

Time Change: -112.75ms (0%)

Total Time: 14,525.25ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 184ms +1.5ms (0%)
Serialization/Write JavaScript string directly 184ms 0ms
Serialization/Swift Int to JavaScript 5,247.25ms -157.25ms (2%)
Serialization/Swift String to JavaScript 5,377.75ms -32.75ms (0%)
Object heap/Increment and decrement RC 3,532.25ms +75.75ms (2%)

performance-action

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0% here is good. I guess we'll need to see it running on more PRs to understand if the variance is really lower with 4 runs instead of 2.

@j-f1 j-f1 merged commit 4f0408d into main Sep 25, 2020
@j-f1 j-f1 deleted the more-perf-tests branch September 25, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants