Cover 100% of core spec tests, support WIT codegen #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is a more detailed breakdown for specific changes: 1. WebAssembly binary parser change to make it compliant with the spec. Files changed: ./Sources/WasmKit/Parser/ ./Tests/WasmKitTests/Parser/ 2. WebAssembly interpreter changes to make it compliant with the spec. No JIT or assembly code generation done in the interpreter. Files changed: ./Sources/WasmKit/Execution/ ./Sources/WasmKit/Types/ ./Tests/WasmKitTests/Execution/ 3. WASI system interface changes to make it compliant with the spec. ./Sources/WASI/ ./Sources/SystemExtras/ ./Tests/WASITests/ ./IntegrationTests/WASI/ 4 .WIT parser change to make it compliant with the Component Model specification. Files changed: ./Sources/WIT/ ./Tests/WITTests/ 5. WIT code generation change. We should mention that this only generates Swift code statically and no binary code is generated. It’s similar to protoc in Protocol Buffers or Swift OpenAPI Generator projects that are already open-source. No “hot reloading” or dynamic code generation is done (i.e. when application is running). Files changed: ./Plugins/ ./Sources/WITExtractor/ ./Sources/WITOverlayGenerator/ ./Sources/WasmKit/Component/ ./Tests/WITExtractorTests/ ./Tests/WITOverlayGeneratorTests/ ./Tests/WITExtractorPluginTests/ Co-authored-by: Yuta Saito <ysaito22@apple.com>
kateinoigakukun
approved these changes
Nov 2, 2023
This was referenced Nov 10, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a more detailed breakdown for specific changes:
Renamed the project from WAKit to WasmKit.
WebAssembly binary parser change to make it compliant with the spec. Files changed:
./Sources/WasmKit/Parser/
./Tests/WasmKitTests/Parser/
WebAssembly interpreter changes to make it compliant with the spec. No JIT or assembly code generation done in the interpreter. Files changed:
./Sources/WasmKit/Execution/
./Sources/WasmKit/Types/
./Tests/WasmKitTests/Execution/
WASI system interface changes to make it compliant with the spec.
./Sources/WASI/
./Sources/SystemExtras/
./Tests/WASITests/
./IntegrationTests/WASI/
WIT parser change to make it compliant with the Component Model specification. Files changed:
./Sources/WIT/
./Tests/WITTests/
WIT code generation change. Files changed:
./Plugins/
./Sources/WITExtractor/
./Sources/WITOverlayGenerator/
./Sources/WasmKit/Component/
./Tests/WITExtractorTests/
./Tests/WITOverlayGeneratorTests/
./Tests/WITExtractorPluginTests/