Use JSKit runtime from SwiftPM resources #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MaxDesiatov
added a commit
to swiftwasm/JavaScriptKit
that referenced
this pull request
May 12, 2022
Due to the fact that swiftlang/swift-package-manager#4306 will only be available starting with Swift 5.7, we can't generate these resources with a SwiftPM plugin. I propose storing the generated code in the repository directly for now. When 5.7 is released, we can switch to a SwiftPM plugin approach. Can be tested end-to-end with swiftwasm/carton#335. Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
MaxDesiatov
commented
May 12, 2022
j-f1
previously approved these changes
May 17, 2022
|
@kateinoigakukun LMK if you're busy, I can either wait until you have time to review or merge as is. Thanks! |
|
Ah, give me 30min for review. |
|
No worries! I don't want to distract you from your work, but at the same time your input is greatly appreciated, especially as it's a large-ish PR. |
MaxDesiatov
commented
May 20, 2022
| @@ -201,7 +202,7 @@ public final class Toolchain { | |||
| } | |||
|
|
|||
| public func inferSourcesPaths() throws -> [AbsolutePath] { | |||
| let manifest = try self.manifest.get() | |||
There was a problem hiding this comment.
Change applied by the formatter.
|
All CI checks are green now, ready for review 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #155.