Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent decode the URI for the static resource requests #491

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jun 24, 2024

I'm having a couple issues with the webserver in carton 1.1.1 that did not happen for the in pre 1.0 carton.

  • Any resource with a space in the path will 404 (the path is correctly percent encoded)
  • Doing a fetch with method HEAD gives 405 (Method Not Allowed)
    • HEAD retrieves file data without downloading the file and is pretty important to my projects for performance

https://discord.com/channels/780838335798706197/953323038299025469/1254480207952482325

@kateinoigakukun kateinoigakukun force-pushed the katei/fix-percent-decoding branch 2 times, most recently from fcf26a2 to 2520ab2 Compare June 24, 2024 05:04
@kateinoigakukun kateinoigakukun force-pushed the katei/fix-percent-decoding branch from 2520ab2 to 42e536f Compare June 24, 2024 05:10
@kateinoigakukun kateinoigakukun marked this pull request as ready for review June 24, 2024 05:39
@kateinoigakukun kateinoigakukun merged commit a18bcb1 into main Jun 24, 2024
6 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/fix-percent-decoding branch June 24, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant