Skip to content

Fix some typos #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix some typos #493

merged 1 commit into from
Aug 19, 2024

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Aug 19, 2024

No description provided.

Sajjon
Sajjon commented Aug 19, 2024
View reviewed changes
Sources/CartonHelpers/Basics/Lock.swift Outdated
@@ -47,7 +47,7 @@ extension NSLock {
}

public enum ProcessLockError: Error {
case unableToAquireLock(errno: Int32)
case unableToAcquireLock(errno: Int32)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this enum is public, so this might be a breaking change for some people?

Sources/CartonHelpers/Basics/HashAlgorithms.swift Outdated
0x6a09_e667, 0xbb67_ae85, 0x3c6e_f372, 0xa54f_f53a, 0x510e_527f, 0x9b05_688c, 0x1f83_d9ab,
0x5be0_cd19,
]

/// The constants in the algorithm (K).
private static let konstants: [UInt32] = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you prefer k.

@kateinoigakukun
Copy link
Member

Sources/CartonHelpers/Basics is derived from swift-tools-core-support, so please keep it as is.

@Sajjon
Copy link
Contributor Author

Sajjon commented Aug 19, 2024

Sources/CartonHelpers/Basics is derived from swift-tools-core-support, so please keep it as is.

Reverted!

@Sajjon
Copy link
Contributor Author

Sajjon commented Aug 19, 2024

CI test failure seems unrelated to changes?

/Users/runner/work/carton/carton/Sources/CartonHelpers/Retry.swift:22: error: -[CartonCommandTests.FrontendDevServerTests testDevServerPublish] : failed: caught error: "Error Domain=NSURLErrorDomain Code=-1004 "Could not connect to the server." UserInfo={_kCFStreamErrorCodeKey=61, NSUnderlyingError=0x6000005adda0 {Error Domain=kCFErrorDomainCFNetwork Code=-1004 "(null)" UserInfo={_NSURLErrorNWPathKey=satisfied (Path is satisfied), viable, interface: lo0, _kCFStreamErrorCodeKey=61, _kCFStreamErrorDomainKey=1}}, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <12BEB431-F1A9-41BE-9C08-F5864D625110>.<10>, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "LocalDataTask <12BEB431-F1A9-41BE-9C08-F5864D625110>.<10>"
), NSLocalizedDescription=Could not connect to the server., NSErrorFailingURLStringKey=http://127.0.0.1:8080/, NSErrorFailingURLKey=http://127.0.0.1:8080/, _kCFStreamErrorDomainKey=1}"
Test Case '-[CartonCommandTests.FrontendDevServerTests testDevServerPublish]' failed (118.981 seconds).
Test Suite 'FrontendDevServerTests' failed at 2024-08-19 07:50:58.117.
	 Executed 1 test, with 1 failure (1 unexpected) in 118.981 (118.981) seconds

@kateinoigakukun kateinoigakukun merged commit 348d9f4 into swiftwasm:main Aug 19, 2024
5 of 6 checks passed
This was referenced Sep 9, 2024
Closed
Draft
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sajjon @kateinoigakukun