Add swiftcc attribute to swift_retain to resolve signature mismatch issue #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match issue The swift_retain has been attributed with swiftcc since swiftwasm/swift@b565d02 Ideally the swiftcc attribute should be removed and swift side caller should call it with C calling convention, but there is no way to declare C function signature in Swift (except for importing from ClangImporter). So this patch is a temporary workaround. Please follow the related forum thread https://forums.swift.org/t/formalizing-cdecl/40677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was revealed while upgrading clang version in swiftwasm/swift#2410
The swift_retain has been attributed with swiftcc since
swiftwasm/swift@b565d02
Ideally the swiftcc attribute should be removed and swift side caller
should call it with C calling convention, but there is no way to declare
C function signature in Swift (except for importing from ClangImporter).
So this patch is a temporary workaround. Please follow the related forum
thread https://forums.swift.org/t/formalizing-cdecl/40677