Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftWasm 5.5 release #3604

Closed
7 of 8 tasks
MaxDesiatov opened this issue Sep 28, 2021 · 13 comments
Closed
7 of 8 tasks

SwiftWasm 5.5 release #3604

MaxDesiatov opened this issue Sep 28, 2021 · 13 comments
Labels
release Issues with the release version

Comments

@MaxDesiatov
Copy link

MaxDesiatov commented Sep 28, 2021

Here's a preliminary list of things that we'd probably want to see completed for the release:

@swiftwasm/toolchain-team WDYT? Anything else you think is required for a successful release? Do you think any of the points above are redundant and we should release ASAP as it is right now?

@MaxDesiatov MaxDesiatov added the release Issues with the release version label Sep 28, 2021
@kateinoigakukun
Copy link
Member

kateinoigakukun commented Sep 28, 2021

IIRC, we need to cherry-pick my recent repairs of cooperative executor swiftlang#39365 swiftlang#39092
And also need to run test/Concurrency/Runtime test cases at least to ensure it works well.
If actor needs to be handled in wasm32 especially, some bugs will be found by the test cases.
(But as far as I understand, we don't need to handle them because only actor implementation (Actor.cpp) cares atomicity and job_enqueue procedure doesn't care it.)

@MaxDesiatov
Copy link
Author

Thanks, I'm doing that in #3606

@MaxDesiatov MaxDesiatov pinned this issue Oct 19, 2021
@cohix
Copy link

cohix commented Oct 27, 2021

@MaxDesiatov what would be the easiest way for me to get a linux/ARM64 build? I'd like to experiment with my own ARM Docker images, as it's become a big blocker for my team.

(Happy to contribute back anything we do, of course!)

@MaxDesiatov
Copy link
Author

After you clone this repository, you can run this script like ./swift/utils/webassembly/ci.sh. This script only supports Ubuntu at the moment. There's also a separate Dockerfile for Amazon Linux. I don't think any of these were tested on ARM64 though.

@cohix
Copy link

cohix commented Oct 28, 2021

@MaxDesiatov Thanks! I will do some experimenting soon.

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 18, 2021

Found another issue in 5.5 (and potentially dev) snapshots, does not look like a blocker to me as I can work around it in carton by passing flags there #3891

@MaxDesiatov
Copy link
Author

carton is now ready for SwiftWasm 5.5, PR is waiting for approval here swiftwasm/carton#263

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 23, 2021

TWIMC, 5.5.0 distribution CI run started here https://github.com/swiftwasm/swift/runs/4301523678?check_suite_focus=true

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 23, 2021

Looks like there's a bug in distribution scripts, where intermittently name of a distribution archive can have a certain timestamp, but the contents of it will have a timestamp for a previous day. I've triggered a new build in the 5.5 branch and I hope the newly produced distribution will be named correctly tomorrow. Will tag 5.5.0 off that new distribution of that snapshot then.

Debugging the script and fixing it may take just as much time as simple re-triggering I've done. But if it's borked again tomorrow, guess I'll have to investigate this thoroughly and fix it.

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 24, 2021

New release is tagged: https://github.com/swiftwasm/swift/releases/tag/swift-wasm-5.5.0-RELEASE, I'll keep it marked as pre-release until Monday, 27th of November, when everyone in the US is back from Thanksgiving holidays, which potentially will give us more coverage/shares when we announce it. I imagine Twitter is pretty quiet right now. Also gives us more time to test and tag new versions of Tokamak and carton.

I got it tagged off wasm-5.5-SNAPSHOT-2021-11-16-a. Later snapshots have their macOS installers (at least those for arm64) seemingly corrupted, but there's little to no difference between wasm-5.5-SNAPSHOT-2021-11-16-a and later snapshots. For distribution script to work without changes I had to delete later 5.5 tags though.

Update: I deleted the tag to avoid confusion, macOS installer packages from this tag couldn't be installed due to notarization issues, see below for updates.

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 24, 2021

ugh, too early to rejoice, this archive also looks corrupted 😢 https://github.com/swiftwasm/swift/releases/download/swift-wasm-5.5.0-RELEASE/swift-wasm-5.5.0-RELEASE-macos_arm64.pkg

Update: it's a macOS notarization issue, investigating

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Nov 24, 2021

The tag is back, it's working. Will be formally announced on Monday 29 Nov if no major issues are found.

@MaxDesiatov
Copy link
Author

Closing as released. We didn't get Linux arm64 builds yet, but it's tracked in a separate issue now. Release announcement is now published on our blog.

@MaxDesiatov MaxDesiatov unpinned this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues with the release version
Projects
None yet
Development

No branches or pull requests

3 participants