Re-enable all Wasm stdlib tests on Linux for 5.3 #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
continuous integration
Member
Author
|
@kateinoigakukun do you know why this would fail on macOS? |
Member
|
I suspect the latest commit on llvm-project of 5.3 branch is related swiftwasm/llvm-project@62bdf96 🤔 |
Member
|
Perhaps, we need to build with released version Xcode 12 |
Member
Author
|
#1799 fails though, I'll try to rebase, but if it passes that would be a pleasant surprise... |
The wasmer cranelift backend is broken since 1.0.0-alpha3, so we use singlepass backend instead until the bug will be resolved. wasmerio/wasmer#1674 # Conflicts: # test/lit.cfg
MaxDesiatov
force-pushed
the
swiftwasm-release/5.3-linux-tests
branch
from
ad0ff0b to
fb77480
Compare
kateinoigakukun
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1900.