Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Crash with useContentChecksums #209

Merged
merged 3 commits into from
Jan 10, 2023
Merged

🐛 Fix Crash with useContentChecksums #209

merged 3 commits into from
Jan 10, 2023

Conversation

mlch911
Copy link
Contributor

@mlch911 mlch911 commented Jan 9, 2023

Description

Fix Crash with useContentChecksums.

References

May crash when cache with useContentChecksums if there's any symlink file.
Shouldn't include these symlink when calculate checksums.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

❤️ Thanks for contributing to the 🏈 Rugby!

@mlch911
Copy link
Contributor Author

mlch911 commented Jan 9, 2023

Fix #208

@swiftyfinch
Copy link
Owner

Thank you for your request!

@swiftyfinch swiftyfinch changed the title Fix Crash with useContentChecksums 🐛 Fix Crash with useContentChecksums Jan 10, 2023
@swiftyfinch
Copy link
Owner

@mlch911 Please, fix lint warning.
As I see, there is an redundant space before {.

@mlch911
Copy link
Contributor Author

mlch911 commented Jan 10, 2023

Sorry, my fault.

@swiftyfinch swiftyfinch added the 🐛 Bug Something isn't working label Jan 10, 2023
@swiftyfinch swiftyfinch added this to the 🏈 Next release milestone Jan 10, 2023
@swiftyfinch swiftyfinch merged commit a01cc7b into swiftyfinch:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftyfinch swiftyfinch swiftyfinch left review comments

Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
🏈 Roadmap
Status: 📦 Done
Milestone
🏈 Next release
Development

Successfully merging this pull request may close these issues.
2 participants
@mlch911 @swiftyfinch