Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Project refactor #265

Merged
merged 2 commits into from
Nov 8, 2023
Merged

⚙️ Project refactor #265

merged 2 commits into from
Nov 8, 2023

Conversation

swiftyfinch
Copy link
Owner

Description

Another one preparation step to #263

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation if necessary
  • 👨🏻‍🔧 Added at least one test that validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Nov 8, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 8, 2023
@swiftyfinch swiftyfinch marked this pull request as ready for review November 8, 2023 19:07
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a1c9da2) 25.39% compared to head (e7a5d0e) 25.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   25.39%   25.36%   -0.03%     
==========================================
  Files         164      164              
  Lines        4725     4730       +5     
==========================================
  Hits         1200     1200              
- Misses       3525     3530       +5     
Files Coverage Δ
...rces/RugbyFoundation/Core/Build/BuildManager.swift 0.00% <ø> (ø)
...yFoundation/Core/Delete/DeleteTargetsManager.swift 0.00% <ø> (ø)
.../RugbyFoundation/Core/Use/UseBinariesManager.swift 4.93% <ø> (ø)
...ces/RugbyFoundation/Vault/Commands/Vault+Use.swift 0.00% <ø> (ø)
.../XcodeProj/Project/Project+DeleteTargetGroup.swift 0.00% <ø> (ø)
...Foundation/XcodeProject/Models/Target/Target.swift 0.00% <ø> (ø)
...gbyFoundation/Core/Build/BuildTargetsManager.swift 0.00% <0.00%> (ø)
...n/Core/Common/XcodeProject/RugbyXcodeProject.swift 0.00% <0.00%> (ø)
.../RugbyFoundation/Core/Rollback/BackupManager.swift 0.00% <0.00%> (ø)
.../RugbyFoundation/XcodeProject/Models/Project.swift 0.00% <0.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch enabled auto-merge (rebase) November 8, 2023 19:13
@swiftyfinch swiftyfinch merged commit 7de0fc6 into main Nov 8, 2023
7 of 9 checks passed
@swiftyfinch swiftyfinch deleted the project-refactor branch November 8, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant