🐛 Use product name instead of module name when patching XCFrameworks

[PRESIDENT810]

Description

When patching support files, we should use just product.name to replace XCFrameworks paths. This is because module name is used for importing modules in swift, which doesn't allow special characters like '-', so for modulemap search path we should use module name; however for header search path and library search path, special characters are allowed. Therefore when we have targets whose name has characters not supported in Swift, such as "foo-bar", using product.moduleName makes the regex pattern for patching XCFrameworks be "${PODS_XCFRAMEWORKS_BUILD_DIR}/foo_bar", which causes search path "${PODS_XCFRAMEWORKS_BUILD_DIR}/foo-bar" cannot be substituted because regex pattern doesn't match.

For example:


For patching modulemap path, we should use product.moduleName which doesn't include special characters like '-', but for patching XCFramework, we should use product.name

Checklist (I have ...)

• 🧐 Followed the code style of the rest of the project
• 📖 Updated the documentation if necessary
• 👨🏻‍🔧 Added at least one test that validates that my change is working, if appropriate
• 👮🏻‍♂️ Run make lint and fixed all warnings
• ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2bfb4b) 26.59% compared to head (743bfad) 26.61%.
Report is 2 commits behind head on main.

❗ Current head 743bfad differs from pull request most recent head ecb7766. Consider uploading reports for the commit ecb7766 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   26.59%   26.61%   +0.01%     
==========================================
  Files         164      164              
  Lines        4756     4757       +1     
==========================================
+ Hits         1265     1266       +1     
  Misses       3491     3491              

Files	Coverage Δ
...RugbyFoundation/Core/Use/SupportFilesPatcher.swift	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PRESIDENT810]

@swiftyfinch Ah sorry, wasn't checking GitHub notifications on weekends... I fixed them and now it should be OK.

[swiftyfinch]

@PRESIDENT810 Thank you for your contribution! 🚀