Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add ability to set shared folder root path #272

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

  • I've renamed the feature toggles service to the environment;
  • And I've added the new environment variable to set shared folder root path.
    Read more in updated docs.

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🚀 Enhancement New feature or request label Nov 18, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8b772fe) 33.10% compared to head (dce3bc6) 33.06%.

Files Patch % Lines
...by/Core/Dependencies/Environment/Environment.swift 0.00% 5 Missing ⚠️
Sources/Rugby/Rugby.swift 0.00% 4 Missing ⚠️
...rces/RugbyFoundation/Core/Build/BuildManager.swift 0.00% 2 Missing ⚠️
...s/Rugby/Core/RunnableCommand/RunnableCommand.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   33.10%   33.06%   -0.04%     
==========================================
  Files         142      142              
  Lines        4156     4161       +5     
==========================================
  Hits         1376     1376              
- Misses       2780     2785       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch added the 🧪 Need testing The pull request should be tested manually label Nov 19, 2023
@swiftyfinch swiftyfinch marked this pull request as ready for review November 20, 2023 16:22
@swiftyfinch swiftyfinch merged commit 30dd83a into main Nov 20, 2023
7 of 9 checks passed
@swiftyfinch swiftyfinch deleted the shared-folder-env branch November 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Enhancement New feature or request 🧪 Need testing The pull request should be tested manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant