Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix getting resources from variant group #291

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

swiftyfinch
Copy link
Owner

Description

I've fixed getting resources from the variant group.
Without this fix a whole pod folder (even non-resources) is added to hash.

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🐛 Bug Something isn't working label Nov 26, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb4647a) 37.24% compared to head (f92628f) 37.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   37.24%   37.30%   +0.06%     
==========================================
  Files         142      142              
  Lines        4172     4176       +4     
==========================================
+ Hits         1554     1558       +4     
  Misses       2618     2618              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch marked this pull request as ready for review November 26, 2023 17:05
@swiftyfinch swiftyfinch merged commit 63811bb into main Nov 26, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the fix-resources-variant-group branch November 26, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant