Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add tests for BuildPhaseHasher #294

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

@swiftyfinch swiftyfinch commented Nov 27, 2023

Description

I've added tests for BuildPhaseHasher.

References

  • #236

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the tests Usually automated testing label Nov 27, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 27, 2023
@swiftyfinch swiftyfinch marked this pull request as ready for review November 27, 2023 18:59
@swiftyfinch swiftyfinch enabled auto-merge (rebase) November 27, 2023 18:59
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (28b32b6) 37.30% compared to head (ea3d7db) 39.54%.

Files Patch % Lines
...ndation/Core/Common/Hashers/BuildRulesHasher.swift 0.00% 1 Missing ⚠️
...n/Core/Common/Hashers/CocoaPodsScriptsHasher.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   37.30%   39.54%   +2.23%     
==========================================
  Files         142      142              
  Lines        4176     4175       -1     
==========================================
+ Hits         1558     1651      +93     
+ Misses       2618     2524      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit d8785b7 into main Nov 27, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the tests-build-phase-hasher branch November 27, 2023 19:06
@swiftyfinch swiftyfinch linked an issue Nov 27, 2023 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Usually automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👨🏻‍🔧 Increase Code Coverage
1 participant