Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add tests for ProductHasher #296

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

I've added tests for ProductHasher.

References

  • #236

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the tests Usually automated testing label Nov 29, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 29, 2023
@swiftyfinch swiftyfinch marked this pull request as ready for review November 29, 2023 17:31
@swiftyfinch swiftyfinch enabled auto-merge (rebase) November 29, 2023 17:31
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1738e1) 39.71% compared to head (8f7a7d3) 39.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   39.71%   39.86%   +0.14%     
==========================================
  Files         142      142              
  Lines        4175     4172       -3     
==========================================
+ Hits         1658     1663       +5     
+ Misses       2517     2509       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 9ab32d9 into main Nov 29, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the tests-product-hasher branch November 29, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Usually automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant