Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add tests for TargetsHasher #299

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

I've added tests for TargetsHasher.

References

  • #236

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the tests Usually automated testing label Dec 1, 2023
@swiftyfinch swiftyfinch self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c2646bd) 41.09% compared to head (4c2fcd6) 42.84%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ndation/Core/Common/Hashers/BuildRulesHasher.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   41.09%   42.84%   +1.75%     
==========================================
  Files         142      142              
  Lines        4171     4166       -5     
==========================================
+ Hits         1714     1785      +71     
+ Misses       2457     2381      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch marked this pull request as ready for review December 1, 2023 19:11
@swiftyfinch swiftyfinch merged commit af77cad into main Dec 1, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the tests-targets-hasher branch December 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Usually automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant