Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add tests for WarmupManager #307

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

I've added tests for WarmupManagerTests.

References

  • #236

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the tests Usually automated testing label Dec 7, 2023
@swiftyfinch swiftyfinch self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5067c83) 47.12% compared to head (9952579) 50.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   47.12%   50.98%   +3.86%     
==========================================
  Files         142      142              
  Lines        4168     4168              
==========================================
+ Hits         1964     2125     +161     
+ Misses       2204     2043     -161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit e0b8314 into main Dec 7, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the test-warmup-manager branch December 7, 2023 12:54
@swiftyfinch swiftyfinch changed the title ⚙️ Add tests for WarmupManagerTests ⚙️ Add tests for WarmupManager Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Usually automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant