Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Refactoring XcodeBuild #334

Merged
merged 3 commits into from
Feb 26, 2024
Merged

⚙️ Refactoring XcodeBuild #334

merged 3 commits into from
Feb 26, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

  • None

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Feb 26, 2024
@swiftyfinch swiftyfinch force-pushed the refactoring-xcodebuild branch from 6650943 to d243119 Compare February 26, 2024 17:22
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@db559dd). Click here to learn what that means.

Files Patch % Lines
...ources/RugbyFoundation/Core/Build/BuildError.swift 0.00% 5 Missing ⚠️
...ion/Core/Build/XcodeBuild/XcodeBuildExecutor.swift 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage        ?   62.14%           
=======================================
  Files           ?      141           
  Lines           ?     3207           
  Branches        ?        0           
=======================================
  Hits            ?     1993           
  Misses          ?     1214           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch enabled auto-merge (rebase) February 26, 2024 17:27
@swiftyfinch swiftyfinch merged commit 0915241 into main Feb 26, 2024
9 checks passed
@swiftyfinch swiftyfinch deleted the refactoring-xcodebuild branch February 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant