Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Refactoring the way to select targets #335

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

  • None

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Feb 26, 2024
@swiftyfinch swiftyfinch self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.37%. Comparing base (0915241) to head (6c7bf72).

Files Patch % Lines
...gbyFoundation/Core/Build/BuildTargetsManager.swift 71.42% 2 Missing ⚠️
...rces/RugbyFoundation/Core/Build/BuildManager.swift 96.15% 1 Missing ⚠️
.../RugbyFoundation/Core/Use/UseBinariesManager.swift 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   62.14%   62.37%   +0.22%     
==========================================
  Files         141      141              
  Lines        3207     3237      +30     
==========================================
+ Hits         1993     2019      +26     
- Misses       1214     1218       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 870f3c3 into main Feb 26, 2024
9 checks passed
@swiftyfinch swiftyfinch deleted the refactoring-targets-scope branch February 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant