Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Copy reference to subproject before fixing relative path #341

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

This request fixes missing bundle product folders after the build process in the multi-project configuration.

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🐛 Bug Something isn't working label Mar 1, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 62.12%. Comparing base (7867bfb) to head (5f00cf5).

Files Patch % Lines
...sions/XcodeProj/PBXProj/PBXProj+Dependencies.swift 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   62.47%   62.12%   -0.35%     
==========================================
  Files         144      144              
  Lines        3419     3438      +19     
==========================================
  Hits         2136     2136              
- Misses       1283     1302      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 671852a into main Mar 1, 2024
7 of 9 checks passed
@swiftyfinch swiftyfinch deleted the fix-missing-bundle-folder branch March 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant