Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Rewrite backup folders instead of copying files #345

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

In some cases it is necessary to rewrite a whole folder during restoring a backup.
For example, when an original Pods folder contains a temporary Rugby scheme.

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🐛 Bug Something isn't working label Mar 2, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 2, 2024
@swiftyfinch swiftyfinch enabled auto-merge (rebase) March 2, 2024 17:01
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.19%. Comparing base (e04a4ba) to head (4c5dd2c).

Files Patch % Lines
.../RugbyFoundation/Core/Rollback/BackupManager.swift 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   62.16%   62.19%   +0.02%     
==========================================
  Files         144      144              
  Lines        3441     3449       +8     
==========================================
+ Hits         2139     2145       +6     
- Misses       1302     1304       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit f45ddb5 into main Mar 2, 2024
9 checks passed
@swiftyfinch swiftyfinch deleted the rewrite-backup-folders branch March 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant