Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿค– Bump minimum macOS and Swift version #359

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

swiftyfinch
Copy link
Owner

  • ๐Ÿง Followed the code style of the rest of the project
  • ๐Ÿ“– Updated the documentation, if necessary
  • ๐Ÿ‘จ๐Ÿปโ€๐Ÿ”ง Added at least one test which validates that my change is working, if appropriate
  • ๐Ÿ‘ฎ๐Ÿปโ€โ™‚๏ธ Run make lint and fixed all warnings
  • โœ… Run make test and fixed all tests

โค๏ธ Thanks for contributing to the ๐Ÿˆ Rugby!

@swiftyfinch swiftyfinch added the workflow GitHub Actions, scripts, etc. label Mar 9, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 9, 2024
@swiftyfinch swiftyfinch enabled auto-merge (rebase) March 9, 2024 14:46
@swiftyfinch swiftyfinch force-pushed the min-macos-swift-version branch from 79c9e3b to be0bd08 Compare March 9, 2024 16:23
@swiftyfinch swiftyfinch force-pushed the min-macos-swift-version branch from be0bd08 to 43c3dd1 Compare March 9, 2024 16:29
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 64.33%. Comparing base (bfcc44e) to head (43c3dd1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   64.43%   64.33%   -0.11%     
==========================================
  Files         146      146              
  Lines        3664     3726      +62     
==========================================
+ Hits         2361     2397      +36     
- Misses       1303     1329      +26     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 5f5cb93 into main Mar 9, 2024
10 of 11 checks passed
@swiftyfinch swiftyfinch deleted the min-macos-swift-version branch March 9, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow GitHub Actions, scripts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant