Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Warmup percents #360

Merged
merged 4 commits into from
Mar 9, 2024
Merged

⚙️ Warmup percents #360

merged 4 commits into from
Mar 9, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

  • I've reworded some log messages about percents in the warmup command;
  • I've added downloaded binaries percent to metics.

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Mar 9, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (5f5cb93) to head (12c065b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   64.33%   64.30%   -0.03%     
==========================================
  Files         146      146              
  Lines        3726     3723       -3     
==========================================
- Hits         2397     2394       -3     
  Misses       1329     1329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch enabled auto-merge (rebase) March 9, 2024 18:08
@swiftyfinch swiftyfinch merged commit 95ecaba into main Mar 9, 2024
11 checks passed
@swiftyfinch swiftyfinch deleted the warmup-percents branch March 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant