Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert backup changes #361

Merged
merged 2 commits into from
Mar 9, 2024
Merged

🐛 Revert backup changes #361

merged 2 commits into from
Mar 9, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

I've reverted backup command changes, because there was an issue with restoring custom (non-Pods) projects.
And I've added removing the RugbyPods scheme outside of restoring process.
This solution looks like more stable one.

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🐛 Bug Something isn't working label Mar 9, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 9, 2024
@swiftyfinch swiftyfinch enabled auto-merge (rebase) March 9, 2024 19:33
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 64.23%. Comparing base (95ecaba) to head (aea3c5a).

Files Patch % Lines
...ources/RugbyFoundation/Core/Test/TestManager.swift 87.50% 2 Missing ⚠️
.../RugbyFoundation/Core/Rollback/BackupManager.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   64.30%   64.23%   -0.07%     
==========================================
  Files         146      146              
  Lines        3723     3722       -1     
==========================================
- Hits         2394     2391       -3     
- Misses       1329     1331       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 794543d into main Mar 9, 2024
11 checks passed
@swiftyfinch swiftyfinch deleted the revert-backup-changes branch March 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant