Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Added resolving env variables in plans #385

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

With these changes plans can access environment variables in three different ways:

usual:
- command: warmup
  argument: $(S3_ENDPOING)
  headers: 'secret-key: ${RUGBY_S3_SECRET_KEY}'
  except: $BAD_POD_TARGET_NAME0

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🚀 Enhancement New feature or request label Mar 27, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.13%. Comparing base (d273ed2) to head (67c4872).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   64.07%   64.13%   +0.06%     
==========================================
  Files         150      150              
  Lines        3908     3929      +21     
==========================================
+ Hits         2504     2520      +16     
- Misses       1404     1409       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch added the 🧪 Need testing The pull request should be tested manually label Mar 27, 2024
Copy link

@kattouf kattouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Docs/commands-help/plan.md Outdated Show resolved Hide resolved
@swiftyfinch swiftyfinch merged commit 1d558ed into main Mar 29, 2024
11 checks passed
@swiftyfinch swiftyfinch deleted the resolve-plans-env branch March 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Enhancement New feature or request 🧪 Need testing The pull request should be tested manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants