Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add ability to load latest release without api request #388

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

swiftyfinch
Copy link
Owner

Description

Due to API rate limits, which allow only 60 requests per hour, I have added another way to avoid these restrictions.
I use the link to the latest release to find the latest tag name, and then we can download the binary directly without making any API calls.

Also, I have shortened the error message and added a helpful hint:

Screenshot 2024-03-29 at 00 52 51

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the 🚀 Enhancement New feature or request label Mar 28, 2024
@swiftyfinch swiftyfinch self-assigned this Mar 28, 2024
@swiftyfinch swiftyfinch force-pushed the update-limits-workaround branch from 2264794 to 26d9cd1 Compare March 28, 2024 20:00
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 64.07%. Comparing base (965770c) to head (26d9cd1).

Files Patch % Lines
.../Dependencies/Update/GitHubReleaseListLoader.swift 0.00% 26 Missing ⚠️
...Rugby/Core/Dependencies/Update/GitHubUpdater.swift 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   64.61%   64.07%   -0.55%     
==========================================
  Files         150      150              
  Lines        3875     3908      +33     
==========================================
  Hits         2504     2504              
- Misses       1371     1404      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit d273ed2 into main Mar 29, 2024
9 of 11 checks passed
@swiftyfinch swiftyfinch deleted the update-limits-workaround branch March 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant