Fixes #1562 #1165 #1158 #1062 #808 #672 #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls update before starting animations to fix gradientId, gradientFill, and gradientStops undefined when data changes.
|
We released a mirrored version of the package the includes the fix @bugsplat/ngx-charts. I tested using this package in all the stackblitz links in the linked issues. I was able to confirm the fix worked in all but #1062 which appears to be a dup of #1165 where I was able to successfully test the fix. |
This was referenced Jun 10, 2021
Closed
|
Thanks Bobby! |
hilel
pushed a commit
to hilel/ngx-charts
that referenced
this pull request
Dec 26, 2021
Calls update before starting animations to fix gradientId, gradientFill, and gradientStops undefined when data changes.
hilel
pushed a commit
to hilel/ngx-charts
that referenced
this pull request
Dec 26, 2021
Calls update before starting animations to fix gradientId, gradientFill, and gradientStops undefined when data changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Line charts display a gray solid fill instead of a colored gradient when additional series are added to the input "results" as shown in #1158 and demonstrated by this stackblitz.
ngx-charts-bug.mov
What is the new behavior?
Line charts show a colored gradient as demonstrated by this stackblitz
ngx-charts-fix.mov
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Calls update before starting animations to fix gradientId, gradientFill, and gradientStops undefined when data changes.
Fixes #1562
Fixes #1165
Fixes #1158
Fixes #1062
Fixes #808
Fixes #672