-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0.3 breaks line rendering with d3-transition #487
Comments
I have the same issue |
me too
|
This happens if you have multiple versions of d3-selection installed. The d3-transition package is attaching itself to a different version than what ngx is using. In my opinion, ngx-graph should list the d3 dependencies as peer dependencies to avoid this issue. However, we were able to work around it by "pinning" a single version of d3-selection. This can be done with npm or yarn. Here's what we did in package.json to get npm to pin a version:
You can list the version that ngx-graph specifies, but 3.0.0 seems to work fine. Here's an issue filed for d3 that kind of talks about the problem: |
We are also facing similar issue in using 8.0.3 with angular 15. Thanks @neodescis for suggesting a workaround, but unfortunately it did not resolved the issue for us. Greatly appreciate any additional recommendations. |
Same error here (Angular 14). Had to rollback to ngx 8.0.2... |
this solved the issue.. it works |
Did also see that issue, got it fixed with |
I've had this issue on 8.2.1. This happens because ngx-graph has Meanwhile this workaround solves the issue in your app's package.json: "overrides": { |
@neodescis this solution works for me in Angular 16. Thank u. |
i am facing with the same issue, this its part of my package.json with dependecies that i have installed.
|
You put "override" atribute in your JSON file? |
en mi caso tengo angular 17 y me funciona tener la versión 8.0.2 de ngx y de d3-selection la versión 3.0.10 |
hi @Kr0san89 . But still only one edge is rendering. Also if i install this dependency as you mentioned - "d3-selection": "^1.2.0", i am getting dependency conflict related warnings for 'd3-selection'. Can you please provide any neat solution for this ? Thanks ! |
you can use As i don't use this override any more i'm not 100% sure, but something like
I created a PR to get d3 dependencies right #513 but unfortunately the maintainers did not merge it yet hope this helps you |
Hi @Kr0san89 . I tried your given suggestion of adding overrides but no luck. only this thing is working for me - adding "d3-selection": "^1.2.0" as part of dependency (which is just giving dependency conflict related npm warnings). |
Also this ngx-graph has dependency on angular core/cli. with angular 17 it is throwing an error |
After a long night trying to get all the connections to draw correctly, I'll share how I managed to do it. Basically, the issue occurs when creating the path, which should set the d attribute ([attr.d]="link.line" ) like this:
A short response on the topic, and here's an example of how the #linkTemplate would look:
I use this version @swimlane/ngx-graph 8.4.0 |
…ion caused by dependency issue. swimlane/ngx-graph#487
Describe the bug
When updating to 8.0.3, some edges do not render and the following error is produced.
The text was updated successfully, but these errors were encountered: