Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a second menu: root.$layer is undefined #212

Closed
Pancakeo opened this issue May 15, 2014 · 6 comments
Closed

Opening a second menu: root.$layer is undefined #212

Pancakeo opened this issue May 15, 2014 · 6 comments

Comments

@Pancakeo
Copy link

This is a duplicate of #105 , which should be re-opened.

Happy to provide detailed repro steps, if needed.

Will also try to fix, as I'm fairly certain the maintainer is dead :)

@Pancakeo Pancakeo reopened this May 15, 2014
@Gorgoon
Copy link

Gorgoon commented Sep 3, 2015

Hi, I have the same issue...

Did you have fixed this issues ?

I'm also trying to fix it :-(

@bbrala
Copy link
Member

bbrala commented Sep 3, 2015

Zh3d, can you give the steps to reproduce the error?

@ghost
Copy link

ghost commented Nov 28, 2015

Hi! I also get the same problem with https://play.freeciv.org which uses this contextMenu.
The error reported by the browser is this: "Cannot read property 'hide' of undefined"

This is the source code line in question:
https://github.com/swisnl/jQuery-contextMenu/blob/master/src/jquery.contextMenu.js#L443

contextmenu-bug

ghost pushed a commit to freeciv/freeciv-web that referenced this issue Nov 28, 2015
@bbrala
Copy link
Member

bbrala commented Nov 28, 2015

Kind of hard for me to debug without steps to reproduce. I kind of need a context or steps to reproduce.

@ghost
Copy link

ghost commented Nov 28, 2015

I've created a pull-request to fix this. I'm not able to reproduce the problem myself, but after running with this fix in production on https://play.freeciv.org for some hours the problem has not occurred again.

@bbrala
Copy link
Member

bbrala commented Dec 2, 2015

i don't really like to merge a fix for something there is not a real defined problem for. But i'll merge this since it cant really break anything and you haven't been the first to notice.

@bbrala bbrala closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants