-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a second menu: root.$layer is undefined #212
Comments
Hi, I have the same issue... Did you have fixed this issues ? I'm also trying to fix it :-( |
Zh3d, can you give the steps to reproduce the error? |
Hi! I also get the same problem with https://play.freeciv.org which uses this contextMenu. This is the source code line in question: |
Kind of hard for me to debug without steps to reproduce. I kind of need a context or steps to reproduce. |
I've created a pull-request to fix this. I'm not able to reproduce the problem myself, but after running with this fix in production on https://play.freeciv.org for some hours the problem has not occurred again. |
i don't really like to merge a fix for something there is not a real defined problem for. But i'll merge this since it cant really break anything and you haven't been the first to notice. |
This is a duplicate of #105 , which should be re-opened.
Happy to provide detailed repro steps, if needed.
Will also try to fix, as I'm fairly certain the maintainer is dead :)
The text was updated successfully, but these errors were encountered: