Do not use .html() to markup accesskey #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| item._beforeAccesskey = matched[1]; | ||
| item._accesskey = matched[2]; | ||
| item._afterAccesskey = matched[3]; | ||
| console.log(matched); |
There was a problem hiding this comment.
Think you forgot a console.log here.
There was a problem hiding this comment.
Oops, thank you!
I'll fix it soon.
|
Wow, did i just catch you right here or something? Changing it in 2 minutes :) |
bbrala
added a commit
that referenced
this pull request
Oct 26, 2015
Do not use .html() to markup accesskey thanks @arai-a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
83e37fb changes .text() back to .html(), and it introduces the XSS risk again, that was once fixed by f3137f2
accesskey's span element should be inserted separately from before/after text, to avoid parsing HTML there.