html5 & callback is not actually working #564 #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve legacy compatibility when building the menu from a HTML5 menu element I propose that you check for the existence of the
onclick
property on thebutton
,menuitem
orcommand
tag and if one does not exist then call the root callback function as a fallback:Therefore becomes:
I have no need for legacy compatibility in my app but this works well for me especially when building large menus using the suckerfish methodology.