#4 Bugfix: improved implementation

swissbib · Mar 28, 2014 · 59dacd3 · 59dacd3
1 parent 31aae09
commit 59dacd3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/module/Libadmin/src/Libadmin/Table/InstitutionTable.php b/module/Libadmin/src/Libadmin/Table/InstitutionTable.php
@@ -186,9 +186,8 @@ private function relationsChanged(array $oldRelations, array $newRelations) {
 
 		//Check the relations for equality
 		foreach ( $oldRelations as $oldRelation ) {
-			$newRelation = $filteredNewRelations[$oldRelation->getPrimaryKey()];
-
-			if ( !$oldRelation->equals($newRelation) ) return true;
+			if ( !array_key_exists($oldRelation->getPrimaryKey(), $filteredNewRelations) ) return true;
+			if ( !$oldRelation->equals($filteredNewRelations[$oldRelation->getPrimaryKey()]) ) return true;
 		}
 
 		return false;