Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color variables are defined two times #316

Closed
gfellerph opened this issue Aug 12, 2022 · 0 comments · Fixed by #361
Closed

Color variables are defined two times #316

gfellerph opened this issue Aug 12, 2022 · 0 comments · Fixed by #361
Assignees
@gfellerph
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Version 5

Comments

@gfellerph
Copy link
Member

CSS color variables are defined two times and thus immediately overwritten. This is unnecessary.

image
@gfellerph gfellerph added 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package labels Aug 12, 2022
@gfellerph gfellerph added this to the Version 5 milestone Aug 12, 2022
@gfellerph gfellerph moved this to 📋 Backlog in Design System Production Board Aug 12, 2022
@gfellerph gfellerph moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Aug 12, 2022
@gfellerph gfellerph self-assigned this Aug 19, 2022
@gfellerph gfellerph moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Aug 19, 2022
@gfellerph gfellerph linked a pull request Aug 19, 2022 that will close this issue
feat(colors)!: prefix all color variables with --post- #360
Closed
@gfellerph gfellerph moved this from 🏗 In progress to 👀 In review in Design System Production Board Aug 19, 2022
@gfellerph gfellerph moved this from 👀 In review to ✅ Done in Design System Production Board Aug 22, 2022
@gfellerph gfellerph linked a pull request Aug 22, 2022 that will close this issue
feat(colors)!: prefix all color variables with --post- #361
Merged
@gfellerph gfellerph removed a link to a pull request Aug 22, 2022
feat(colors)!: prefix all color variables with --post- #360
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfellerph gfellerph

Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Version 5
Development

Successfully merging a pull request may close this issue.

feat(colors)!: prefix all color variables with --post- swisspost/design-system
1 participant
@gfellerph