feat(colors)!: prefix all color variables with --post- #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes is an overhaul of colors and how they are presented to the developer. Colors defined by the Post now have the prefix --post, variables defined by bootstrap have the prefix --bs. The code has been generally updated to use post variables wherever variables were used already. Many components don't use variables and have yet to be migrated. The idea of contrast colors is, that they always provide the best contrast on their current background - provided the bg-* classes were used to set said background.
🦋 Changeset detectedLatest commit: 5ee031b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Preview environment ready: https://preview-361--swisspost-web-frontend.netlify.app |
gfellerph
changed the title
gfellerph
changed the title
oliverschuerch
requested changes
Aug 19, 2022
oliverschuerch
requested changes
Aug 22, 2022
oliverschuerch
approved these changes
Aug 22, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is an overhaul of colors and how they are presented to the developer. Colors defined by the Post now have the prefix --post, variables defined by bootstrap have the prefix --bs. The code has been generally updated to use post variables wherever variables were used already. Many components don't use variables and have yet to be migrated.
The idea of contrast colors is, that they always provide the best contrast on their current background - provided the bg-* classes were used to set said background.