Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major design changes #3490

Open
1 task
alizedebray opened this issue Sep 3, 2024 · 1 comment
Open
1 task

Major design changes #3490

alizedebray opened this issue Sep 3, 2024 · 1 comment

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Sep 3, 2024

Update the contribution guidelines with the outcome of hereunder discussion.

=> Major changes in the design should be considered as breaking changes for the design system packages.

Tasks

@alizedebray alizedebray added the 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Sep 3, 2024
@gfellerph
Copy link
Member

  • New disabled styles were not technically breaking, but visually. Should this have been a breaking change?
  • The information was there, but projects are not happy with the change
  • Versioning rules are just about code, not about design. Create the possibility to add a major version even if the code is not breaking
  • Projects are not happy with the current disabled styles (strikethrough)
  • We changed disabled styles for accessibility reasons so it's not possible to revert to a non-accessible state, maybe people are also using it wrong
  • Disabled elements are not accessible either way
  • Disabled buttons were implemented a little wrong, so the design change broke their page. A minor change resulted in a lot of work. With a major change, expectation would have been different
  • We could not predict that this would break with incorrect usage
  • Depends on how often we do design breaking changes (should not be too often)
  • Inform Design Team about pending major changes so design changes can be implemented as well

Actions

  • Take major design changes into consideration when deciding for major release versions

@alizedebray alizedebray added ❇️ good first issue Good for newcomers and removed 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. labels Sep 3, 2024
@alizedebray alizedebray changed the title Design breaking changes Major design changes Sep 3, 2024
@gfellerph gfellerph removed the ❇️ good first issue Good for newcomers label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💻 Ready for development
Development

No branches or pull requests

2 participants