Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up alert/toast styles #352

Closed
Tracked by #1215
gfellerph opened this issue Aug 17, 2022 · 0 comments · Fixed by #1350
Closed
Tracked by #1215

Clean up alert/toast styles #352

gfellerph opened this issue Aug 17, 2022 · 0 comments · Fixed by #1350
Assignees
@alizedebray
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Maintenance

Comments

@gfellerph
Copy link
Member

Alert and toast styling relies on a series of complicated placeholders. This makes it hard to update or change styles for these components. Clean up and simplify the styling, maybe use a mixin instead of a placeholder.
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Aug 17, 2022
@gfellerph gfellerph added this to the Web Styles Next milestone Aug 17, 2022
gfellerph added a commit that referenced this issue Aug 17, 2022
@gfellerph
style: linter seems broken when dealing with placeholders
cf5cdfe 
It's an unusual pattern anyways. Created a ticket (#352) to remedy this situation.
gfellerph added a commit that referenced this issue Aug 18, 2022
@gfellerph
fix(alert): icons in high contrast mode (#351)
ba3939d 
Alerts with custom icons face the problem that those icons are black. Inversion techniques don't work because it would invert the whole alert. Creating white alternatives for all possible icons would blow up CSS size too much with current approaches so it's not viable. This approach just replaces custom icons with the default alert icon. This way, only a small set of white icons has to be created.

The linter seems broken when dealing with placeholders, but it's an unusual pattern anyways. Created a ticket (#352) to remedy this situation.
@gfellerph gfellerph modified the milestones: Next, Version 5.1 Nov 2, 2022
@gfellerph gfellerph modified the milestones: Styles v5.1, Next Nov 15, 2022
@gfellerph gfellerph mentioned this issue Feb 3, 2023
Closed
@gfellerph gfellerph added the 🐞 bug Something isn't working label Mar 30, 2023
@gfellerph gfellerph modified the milestones: Next, Maintenance Mar 30, 2023
@alizedebray alizedebray self-assigned this Apr 17, 2023
@alizedebray alizedebray linked a pull request Apr 19, 2023 that will close this issue
fix(styles): clean up alert and toast styles #1350
Merged
@gfellerph gfellerph mentioned this issue Aug 9, 2023
Open
@gfellerph gfellerph mentioned this issue Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Maintenance
Development

Successfully merging a pull request may close this issue.

fix(styles): clean up alert and toast styles swisspost/design-system
2 participants
@gfellerph @alizedebray