Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): Product card with dark background do not render correct color #2818

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Mar 20, 2024

No description provided.

@imagoiq imagoiq self-assigned this Mar 20, 2024
@imagoiq imagoiq requested a review from a team as a code owner March 20, 2024 07:39
@imagoiq imagoiq requested a review from oliverschuerch March 20, 2024 07:39
Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 5fc9879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -217,7 +217,7 @@ export const Multipart: Story = {
</dl>
</div>

<div class="card-body">
<div class="card-body bg-light">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses similar classes as other parts like line 205

@imagoiq imagoiq linked an issue Mar 20, 2024 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 20, 2024

Preview environment ready: https://preview-2818--swisspost-design-system-next.netlify.app

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add bg-white to the white sections as well, the text stops turning invisible on hover. This is a bugfix that we should inform users about, please add a changeset as well.

@imagoiq imagoiq requested a review from gfellerph March 20, 2024 17:19
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imagoiq imagoiq merged commit c57ffc5 into main Mar 21, 2024
7 of 8 checks passed
@imagoiq imagoiq deleted the fix/2690-color-contrast-product-card-dark-bg branch March 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y – Check color-contrast on Product Card with dark background
3 participants