Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(styles): tokenize containers #3982

Merged
merged 19 commits into from
Nov 28, 2024
Merged

chore(styles): tokenize containers #3982

merged 19 commits into from
Nov 28, 2024

Conversation

alizedebray
Copy link
Contributor

No description provided.

@alizedebray alizedebray added the 🚂 PR train PR which follows another one. label Nov 13, 2024
@alizedebray alizedebray added this to the PPNL Components milestone Nov 13, 2024
@alizedebray alizedebray self-assigned this Nov 13, 2024
@alizedebray alizedebray requested review from a team as code owners November 13, 2024 12:42
@alizedebray alizedebray requested review from gfellerph and removed request for a team November 13, 2024 12:42
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 3825103

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Major
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Major
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-components-react Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Major
@swisspost/design-system-icons Major
@swisspost/design-system-migrations Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 13, 2024

Related Previews

Base automatically changed from 3975-remove-rg-and-xxl-breakpoints to main November 19, 2024 08:14
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 169 files on bitbucket and 33 files on GitHub using "col-rg-" on internal projects. Can you add a major changeset describing the change and how to map it to the new class name?

Comment on lines 5 to 6
@use './../themes/bootstrap/core' as *;
@use './../themes/bootstrap/grid' as bg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be removed in a separate PR?

@alizedebray alizedebray linked an issue Nov 20, 2024 that may be closed by this pull request
1 task
@alizedebray alizedebray removed the 🚂 PR train PR which follows another one. label Nov 21, 2024
@alizedebray alizedebray merged commit adc1e8a into main Nov 28, 2024
9 checks passed
@alizedebray alizedebray deleted the 3900-component-container branch November 28, 2024 13:23
gfellerph pushed a commit that referenced this pull request Dec 4, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @swisspost/design-system-styles@9.0.0-next.7

### Major Changes

- Removed deprecated `valid-tooltip` and `invalid-tooltip` classes. (by
[@leagrdv](https://github.com/leagrdv) with
[#4076](#4076))

- Removed the `rg` and `xxl` grid breakpoints, reducing the grid to 5
breakpoints instead of the previous 7. This change affects all CSS
classes tied to specific breakpoints (e.g., `col-rg-2`, `m-xxl-4`).
    **Previous Breakpoints**:

    -   `xs: 0px`
    -   `sm: 400px`
    -   `rg: 600px`
    -   `md: 780px`
    -   `lg: 1024px`
    -   `xl: 1280px`
    -   `xxl: 1440px`

    **New Breakpoints**:

    -   `xs: 0px`
    -   `sm: 600px`
    -   `md: 780px`
    -   `lg: 1024px`
    -   `xl: 1280px`

To maintain compatibility with the updated grid system, you need to
update your code by replacing any `*-rg-*` classes with `*-sm-*`, and
any `*-xxl-*` classes with `*-xl-*`. For example:

    -   `col-rg-2` → `col-sm-2`
- `m-xxl-4` → `m-xl-4` (by
[@alizedebray](https://github.com/alizedebray) with
[#3982](#3982))

- Removed deprecated `carousel` component. (by
[@leagrdv](https://github.com/leagrdv) with
[#4075](#4075))

### Patch Changes

- Updated the grid padding and gutters. (by
[@alizedebray](https://github.com/alizedebray) with
[#4045](#4045))

- Updated the styles of the form validation messages to match the new
Post design. (by [@myrta2302](https://github.com/myrta2302) with
[#3824](#3824))

## @swisspost/design-system-components@9.0.0-next.7

### Minor Changes

- Added the `post-togglebutton` component. (by
[@veyaromain](https://github.com/veyaromain) with
[#3889](#3889))

- Refactored `post-icon` component to use the `<use>` tag to load and
show icons under the hood. This enables responsive icons, enables better
caching and improves render performance slightly. There is no further
action required. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#3969](#3969))

### Patch Changes

- Fixed bug that showed delayed tooltip even after blur event. (by
[@leagrdv](https://github.com/leagrdv) with
[#4053](#4053))

- Made `post-icon` component use base tag href to define location of
icons folder. (by [@leagrdv](https://github.com/leagrdv) with
[#4069](#4069))

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/design-system-icons@9.0.0-next.7

### Minor Changes

- Added a new set of responsive UI icons. These new icons can be used
with the `post-icon` component. These new icons will change their shape
based on their size: small icons will render with less flourish and are
optimised for a smaller pixel grid. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#3969](#3969))

## @swisspost/design-system-components-angular@9.0.0-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@9.0.0-next.7

## @swisspost/design-system-components-react@9.0.0-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@9.0.0-next.7

## @swisspost/design-system-intranet-header@9.0.0-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/design-system-styles-primeng@9.0.0-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/design-system-migrations@9.0.0-next.7



## @swisspost/design-system-tokens@9.0.0-next.7



## @swisspost/design-system-documentation@6.0.0-next.8

### Major Changes

- Removed deprecated `carousel` component. (by
[@leagrdv](https://github.com/leagrdv) with
[#4075](#4075))

### Minor Changes

- Added the `post-togglebutton` component. (by
[@veyaromain](https://github.com/veyaromain) with
[#3889](#3889))

- Updated the documentation navigation. (by
[@alizedebray](https://github.com/alizedebray) with
[#4072](#4072))

- Created a documentation page for the form hints. (by
[@leagrdv](https://github.com/leagrdv) with
[#4086](#4086))

### Patch Changes

- Removed the `rg` and `xxl` grid breakpoints, reducing the grid to 5
breakpoints instead of the previous 7. This change affects all CSS
classes tied to specific breakpoints (e.g., `col-rg-2`, `m-xxl-4`).
    **Previous Breakpoints**:

    -   `xs: 0px`
    -   `sm: 400px`
    -   `rg: 600px`
    -   `md: 780px`
    -   `lg: 1024px`
    -   `xl: 1280px`
    -   `xxl: 1440px`

    **New Breakpoints**:

    -   `xs: 0px`
    -   `sm: 600px`
    -   `md: 780px`
    -   `lg: 1024px`
    -   `xl: 1280px`

To maintain compatibility with the updated grid system, you need to
update your code by replacing any `*-rg-*` classes with `*-sm-*`, and
any `*-xxl-*` classes with `*-xl-*`. For example:

    -   `col-rg-2` → `col-sm-2`
- `m-xxl-4` → `m-xl-4` (by
[@alizedebray](https://github.com/alizedebray) with
[#3982](#3982))

-   Updated dependencies:
    -   @swisspost/design-system-components@9.0.0-next.7
    -   @swisspost/design-system-styles@9.0.0-next.7
    -   @swisspost/design-system-icons@9.0.0-next.7
    -   @swisspost/design-system-components-react@9.0.0-next.7
    -   @swisspost/internet-header@2.0.0-next.7

## @swisspost/design-system-components-angular-workspace@1.1.10-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@9.0.0-next.7
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/internet-header@2.0.0-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/design-system-intranet-header-workspace@3.0.22-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

## @swisspost/design-system-intranet-header-showcase@1.0.10-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-intranet-header@9.0.0-next.7

## @swisspost/design-system-nextjs-integration@0.1.14-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7
    -   @swisspost/design-system-components-react@9.0.0-next.7
    -   @swisspost/internet-header@2.0.0-next.7

## @swisspost/design-system-styles-primeng-workspace@1.0.6-next.7

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@9.0.0-next.7

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component]: Container
3 participants