Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): use base tag href if defined for post-icon (#4069) #4128

Merged

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 2, 2024

No description provided.

@leagrdv leagrdv requested a review from a team as a code owner December 2, 2024 15:53
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: e8d2e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 2, 2024

Related Previews

Copy link

sonarqubecloud bot commented Dec 2, 2024

@leagrdv leagrdv linked an issue Dec 5, 2024 that may be closed by this pull request
@leagrdv leagrdv merged commit ad92ead into release/v8 Dec 5, 2024
10 checks passed
@leagrdv leagrdv deleted the 3787-v8-bug-post-icon-base-path-doesnt-respect-base-tag branch December 5, 2024 11:24
gfellerph pushed a commit that referenced this pull request Dec 9, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to release/v8, this
PR will be updated.


# Releases
## @swisspost/design-system-components@8.6.2

### Patch Changes

- Made `post-icon` component use base tag href to define location of
icons folder. (by [@leagrdv](https://github.com/leagrdv) with
[#4128](#4128))
-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-components-angular@8.6.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@8.6.2

## @swisspost/internet-header@1.15.3

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-intranet-header@8.6.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-styles@8.6.2

### Patch Changes

- Fixed visibility issue with checkbox icon. (by
[@schaertim](https://github.com/schaertim) with
[#4149](#4149))

## @swisspost/design-system-styles-primeng@8.6.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-icons@8.6.2



## @swisspost/design-system-migrations@8.6.2



## @swisspost/design-system-components-angular-workspace@1.1.17

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2
    -   @swisspost/design-system-components@8.6.2

## @swisspost/design-system-components-react@8.6.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@8.6.2

## @swisspost/design-system-demo@8.0.10

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2
    -   @swisspost/design-system-intranet-header@8.6.2
    -   @swisspost/design-system-migrations@8.6.2

## @swisspost/design-system-documentation@5.5.5

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2
    -   @swisspost/design-system-components@8.6.2
    -   @swisspost/internet-header@1.15.3
    -   @swisspost/design-system-components-react@8.6.2
    -   @swisspost/design-system-icons@8.6.2

## @swisspost/design-system-intranet-header-workspace@3.0.29

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-intranet-header-showcase@1.0.17

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-intranet-header@8.6.2

## @swisspost/design-system-nextjs-integration@0.1.21

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2
    -   @swisspost/internet-header@1.15.3
    -   @swisspost/design-system-components-react@8.6.2

## @swisspost/design-system-styles-primeng-workspace@1.0.13

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@8.6.2

## @swisspost/design-system-tokens@8.6.2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: post-icon base path doesn't respect base tag
3 participants