-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LGVISIUM-89: Improved clipping behavior documentation #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stijnvermeeren-swisstopo I managed to address all your comments and to fix the formatting issue in the OpenAI docs (see above). Thank you, for your feedback. I do believe this improved the usability for the API users! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added three minor fixes. Now everything looks good to me!
I clarified the clipping behavior via tests and documented them in the ticket JIRA. I also clarified how I generated the test documents. The OpenAPI endpoints were also clarified so that users are aware of the data extraction behavior when using the bounding boxes to extract coordinates, number or text.