Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGVISIUM-89: Improved clipping behavior documentation #103

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Conversation

dcleres
Copy link
Contributor

@dcleres dcleres commented Oct 31, 2024

I clarified the clipping behavior via tests and documented them in the ticket JIRA. I also clarified how I generated the test documents. The OpenAPI endpoints were also clarified so that users are aware of the data extraction behavior when using the bounding boxes to extract coordinates, number or text.

Copy link

github-actions bot commented Oct 31, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/stratigraphy
   __init__.py8188%11
   extract.py1921920%3–477
   get_files.py19190%3–47
   main.py1191190%3–314
src/stratigraphy/benchmark
   ground_truth.py21195%47
src/stratigraphy/data_extractor
   data_extractor.py57395%33, 66, 103
src/stratigraphy/depthcolumn
   boundarydepthcolumnvalidator.py412051%47, 57, 60, 81–84, 110–128, 140–149
   depthcolumn.py2238064%25, 29, 50, 67, 72, 78, 86–92, 113, 116, 124–125, 141–143, 150, 157, 165–166, 176, 193–209, 247, 255–256, 272–274, 312, 331–339, 350, 355, 362, 393, 398–405, 420–421, 464–506
   depthcolumnentry.py361072%17, 21, 37, 52, 55, 72, 81, 98–100
   find_depth_columns.py1061982%42–43, 73, 86, 180–181, 225–245
src/stratigraphy/depths_materials_column_pairs
   depths_materials_column_pairs.py18667%23, 34, 55–59
src/stratigraphy/evaluation
   evaluation_dataclasses.py491667%24, 33, 42–44, 52, 71–74, 90, 104, 125–131, 137
   metadata_evaluator.py381463%52–71, 94–101
src/stratigraphy/groundwater
   groundwater_extraction.py1479833%44, 52, 83, 98, 106, 125, 152–156, 171–191, 202–291, 307–339
   utility.py393315%10–17, 30–47, 59–73, 88–102
src/stratigraphy/layer
   layer.py371851%29, 39, 57–94, 106–107
   layer_identifier_column.py745230%16–17, 20, 28, 43, 47, 51, 59–63, 66, 74, 91–96, 99, 112, 125–126, 148–158, 172–199
src/stratigraphy/lines
   geometric_line_utilities.py86298%81, 131
   line.py51492%25, 50, 60, 110
   linesquadtree.py46198%75
src/stratigraphy/metadata
   coordinate_extraction.py108595%30, 64, 94–95, 107
   elevation_extraction.py795234%34, 42, 50, 66–69, 106–120, 132–135, 147–179, 194–202, 210–214
   language_detection.py181328%17–23, 37–45
   metadata.py662464%27, 83, 101–127, 146–155, 195–198, 206
src/stratigraphy/text
   description_block_splitter.py70297%24, 139
   extract_text.py29390%19, 53–54
   find_description.py642856%27–35, 50–63, 79–95, 172–175
   textblock.py80989%28, 56, 64, 89, 101, 124, 145, 154, 183
src/stratigraphy/util
   dataclasses.py32391%37–39
   interval.py1045547%29–32, 37–40, 46, 52, 56, 66–68, 107–153, 174, 180–196
   predictions.py1054161%74–78, 86–94, 171–203, 242, 265–283
   util.py391756%41, 69–76, 90–92, 116–117, 129–133
TOTAL220796057% 

Tests Skipped Failures Errors Time
89 0 💤 0 ❌ 0 🔥 8.414s ⏱️

Copy link
Contributor

@stijnvermeeren-swisstopo stijnvermeeren-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Can we get Swagger UI to display the all of attribute documentation in regular font (as is the case for y0 thanks to the redundant quotes) instead of this purple monospace font?

src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
src/app/common/schemas.py Outdated Show resolved Hide resolved
@dcleres
Copy link
Contributor Author

dcleres commented Nov 7, 2024

Screenshot 2024-11-07 at 11 27 21

@stijnvermeeren-swisstopo I managed to address all your comments and to fix the formatting issue in the OpenAI docs (see above). Thank you, for your feedback. I do believe this improved the usability for the API users!

Copy link
Contributor

@stijnvermeeren-swisstopo stijnvermeeren-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added three minor fixes. Now everything looks good to me!

@dcleres dcleres merged commit a5d0947 into main Nov 7, 2024
3 checks passed
@stijnvermeeren-swisstopo stijnvermeeren-swisstopo deleted the LGVISIUM-89 branch November 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants