add audiobookshelf install sh #1028
Conversation
|
Thanks for the contribution lupu60. I have a few items of feedback:
|
|
Hello @liaralabs.
|
| __add_to_pannel(){ | ||
| curl -o /opt/swizzin/static/img/apps/audiobookshelf.png https://www.audiobookshelf.org/Logo.png | ||
| # Content to write | ||
| content='from core.profiles import *\n\n | ||
| class audiobookshelf_meta:\n | ||
| name = "audiobookshelf"\n | ||
| pretty_name = "Audiobookshelf"\n | ||
| baseurl = "/audiobookshelf"\n | ||
| systemd = "audiobookshelf"\n | ||
| check_theD = True' | ||
|
|
||
| # Write content to the file | ||
| echo -e "$content" > /opt/swizzin/core/custom/profiles.py | ||
|
|
||
| echo "Content has been written to /opt/swizzin/core/custom/profiles.py" | ||
| touch /install/.audiobookshelf.lock | ||
| systemctl restart panel | ||
| } |
There was a problem hiding this comment.
Could you remove this and make a PR on the panel repo please? Let me know if you need help in the discord
| # Audiobookshelf installer | ||
|
|
||
| _install_audiobookshelf() { | ||
| echo_progress_start "Installing audiobookshelf apt sources" |
There was a problem hiding this comment.
echo_progress_start kind of expects an echo_progress_done, think of the two as the slices of bread in a waiting sandwich
|
|
||
| _install_audiobookshelf() { | ||
| echo_progress_start "Installing audiobookshelf apt sources" | ||
| apt install gnupg curl |
There was a problem hiding this comment.
We have apt_install defined which helps handle these without the interactivity
There was a problem hiding this comment.
You can use it like this, it is imported into the environment anytime you run box, you can check sources/globals.sh to see what else there is
| apt install gnupg curl | |
| apt_install gnupg curl |
| curl -s https://advplyr.github.io/audiobookshelf-ppa/KEY.gpg | apt-key add - | ||
| curl -s -o /etc/apt/sources.list.d/audiobookshelf.list https://advplyr.github.io/audiobookshelf-ppa/audiobookshelf.list | ||
| apt update | ||
| apt install audiobookshelf |
There was a problem hiding this comment.
Same as above, would be nice to keep the apt installs to one call with one big list in my opinion
| __remove_from_pannel() { | ||
| content= 'from core.profiles import *\n\n' | ||
| echo -e "$content" > /opt/swizzin/core/custom/profiles.py | ||
| } |
There was a problem hiding this comment.
Again, not really needed if it's in the panel repo
| apt update | ||
| apt autoremove |
There was a problem hiding this comment.
We've got apt functions for these two, but I don't think you need to do the update here, just takes time. The apt tools will auto-update themselves as they're being called if necessary
| systemctl stop audiobookshelf.service | ||
| sysctl disable audiobookshelf.service |
There was a problem hiding this comment.
disable also takes --now parameter so you can get these done in one line. Would also be nice to pass the -q flag so it's quiet
Add installation for audiobookshelf
Description
Add installation for audiobookshelf
Change Categories
Checklist
developbranch and the PR is targetting thedevelopbranchTest scenarios
Architectures
amd64armhfarm64✅❎ Passed
🛠🛠 TODO
❌❌ Currently failing