Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGL Graph Serialization #68

Merged
merged 8 commits into from
Jul 28, 2021
Merged

Conversation

marip8
Copy link
Collaborator

@marip8 marip8 commented Jul 26, 2021

This PR adds the ability to serialize a boost graph to a .dot file for visualization of BGL implementations of the solver

image

@marip8
Copy link
Collaborator Author

marip8 commented Jul 26, 2021

@colin-lewis-19 can you review this as well?

@colin-lewis-19
Copy link
Contributor

colin-lewis-19 commented Jul 27, 2021

This looks good to me, and worked as expected when I ran it.
I don't feel like the implementation files are so large that we need to be splitting one class across multiple .hpp's, since that can hurt readability.

Edit: The bgl_ladder_graph_solver is going to continue to grow though and I am not opposed to getting ahead of a refactor.

The rest of descartes_light uses header guards instead of #pragma once though

@marip8
Copy link
Collaborator Author

marip8 commented Jul 27, 2021

I don't feel like the implementation files are so large that we need to be splitting one class across multiple .hpp's, since that can hurt readability.

Good point. I think now that we have the custom vertex class, the graph serialization can be a stand-alone function. I'll move them out so they're separate and can be used by other BGL implementations (provided those implementations use the same graph typedefs)

@marip8 marip8 merged commit 53dd1f9 into swri-robotics:master Jul 28, 2021
@marip8 marip8 deleted the feature/graph_file branch July 28, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants