Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Build #90

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Fix Windows Build #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59870d5
Renamed windows build CI configuration file
marip8 Apr 19, 2022
8c71fc1
Set windows image to 2019 and use nmake
marip8 Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/windows_melodic_build.yml → .github/workflows/windows_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ on:
jobs:
windows_ci:
name: Noetic
runs-on: windows-latest
env:
ROS_DISTRO: noetic
runs-on: windows-2019
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -22,16 +20,18 @@ jobs:
- name: Build
shell: cmd
run: |
choco sources add -n=roswin -s https://aka.ms/ros/public --priority 1
choco install ros-%ROS_DISTRO%-desktop_full -y --no-progress
set ChocolateyInstall=C:\opt\chocolatey
choco sources add -n=ros-win -s="https://aka.ms/ros/public" --priority=1

call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64
call "C:\opt\ros\%ROS_DISTRO%\x64\setup.bat"

python -m pip install vcstool -q
python -m pip install colcon-common-extensions -q
choco install console_bridge -y --no-progress
choco install clapack -y --no-progress
choco install openblas -y --no-progress
choco install boost -y --no-progress
choco install eigen -y --no-progress
refreshenv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be switched to call RefreshEnv.cmd calling refreshenv automatically exits the bash and never builds or runs the test.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Now that you mention it, I do vaguely recall trying that in a prior attempt and seeing the same thing. I just opened #91 to address. I'll check that it actually builds before merging


vcs import --input "${{ github.workspace }}/src/descartes_light/dependencies.rosinstall" src/

catkin_make_isolated --cmake-args -DCMAKE_BUILD_TYPE=Release -DDESCARTES_ENABLE_TESTING=ON
colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release -DDESCARTES_ENABLE_TESTING=ON -DCMAKE_PREFIX_PATH=C:\opt\rosdeps