-
Notifications
You must be signed in to change notification settings - Fork 70
mdcat panics if image title is in two lines #194
Comments
It probably is; I've never seen this before and it doesn't seem to be part of the common mark test suite, so I don't think mdcat handles this. I'll perhaps fix this at some point but it'll take time; to me this is a weird corner case so until I actually hit a document with this it's pretty low on my priority list. If you need to have this fixed any time soon please do open a pull request. |
I agree, just add why this happens: pandoc converts html to markdown and if an image has a long line, pandoc will break it into two lines and cause mdcat to misbehave, e.g.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Can you please fix the formatting of your comment? I've only skimmed it but the actual error seems to be that images don't get shown in kitty? If so that's a separate problem; please open a new issue for this. |
@norman-abramovitz Friendly ping. Please fix the syntax of your comment; I've hidden it meanwhile. You might also want to run |
Hi, I was attempting to reproduce the original issue and not introduce a new issue and provide additional information that I found. I will try the detect-only option when I look at this issue again. I do have iterm2 and kitty on my mac, but I do launch them independently. Maybe some env vars getting in the way. |
Closing this, because it doesn't affect me. |
Those cases are actually covered in the 'commonmark-spec' test suite. However, those tests use non-existent images so they are not checked for rendered images. As such, in this commit we add a new case in 'samples/images.md', primarily to test markups in descriptions of rendered images. Re: swsnrGH-194, swsnrGH-285.
Those cases are actually covered in the 'commonmark-spec' test suite. However, those tests use non-existent images so they are not checked for rendered images. As such, in this commit we add a new case in 'samples/images.md', primarily to test markups in descriptions of rendered images. Re: swsnrGH-194, swsnrGH-285.
Not quite sure if this is a mdcat bug: if I split the image line into two lines as below, run
mdcat test.md
under kitty will abort as shown below.test.md
run
mdcat test.md
it will report below errors:put test.md above into one line it works fine.
The text was updated successfully, but these errors were encountered: