-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release #917
New Release #917
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e439b05 - Browse repository at this point
Copy the full SHA e439b05View commit details -
lsp: Implement a
${defaultBuildDir}
config variableUnless esbonio finds a `sphinx-build` command to use from the user's config it will attempt to guess something reasonable. During this process it generates a default build directory to use, in a subfolder of `platformdirs.user_cache_dir()` so that it does not interfere with the user's files. Up until now, the moment a user sets their own `sphinx-build` command this behavior is lost, which can lead to issues on some systems (see #865). This commit introduces a `${defaultBuildDir}` placeholder value that the user can use to provide their own build flags, while maintaining the default choice of build dir provided by esbonio.
Configuration menu - View commit details
-
Copy full SHA for f2b0082 - Browse repository at this point
Copy the full SHA f2b0082View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd55dd9 - Browse repository at this point
Copy the full SHA dd55dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0027e53 - Browse repository at this point
Copy the full SHA 0027e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea91f01 - Browse repository at this point
Copy the full SHA ea91f01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f19d97 - Browse repository at this point
Copy the full SHA 7f19d97View commit details -
lsp: Ensure filepaths are properly escaped
Backslashes in Windows filepaths can cause issues ```python >>> import re >>> VARIABLE = re.compile(r"\$\{(\w+)\}") >>> VARIABLE.sub('\\path\\to\\cache', '${defaultBuildDir}/doctrees') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib64/python3.12/re/__init__.py", line 334, in _compile_template return _sre.template(pattern, _parser.parse_template(repl, pattern)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/re/_parser.py", line 1075, in parse_template raise s.error('bad escape %s' % this, len(this)) from None re.error: bad escape \p at position 0 ``` Calling `re.escape` on the replacement ensures that characters like backslashes are escaped correctly ```python >>> VARIABLE.sub(re.escape('\\path\\to\\cache'), '${defaultBuildDir}/doctrees') '\\path\\to\\cache/doctrees' >>> ```
Configuration menu - View commit details
-
Copy full SHA for 3e1eb23 - Browse repository at this point
Copy the full SHA 3e1eb23View commit details -
lsp: Create a placeholder for a client at the given scope
When `manager.get_client` is called many times in quick succession (such as on server restart with N files open) this can fool the `SphinxManager` into creating multiple client instances for a given configuration scope. By storing a ``None`` at the relevant scope we allow the SphinxManager to detect that the scope has already been handled, preventing the spawning of duplicated client instances. This should, finally, fix the flaky test issue (#859)
Configuration menu - View commit details
-
Copy full SHA for c89ec6b - Browse repository at this point
Copy the full SHA c89ec6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca88887 - Browse repository at this point
Copy the full SHA ca88887View commit details -
code: Compare the string representation of URIs
For some reason, the object representation of the same URI is not stable leading to synchronised scrolling breaking after scrolling the preview window. Instead, compare the string representation of the uris which should work around the differences that should not matter.
Configuration menu - View commit details
-
Copy full SHA for 8f0e644 - Browse repository at this point
Copy the full SHA 8f0e644View commit details -
sphinx-agent: Rewrite internal links
As part of its initial setup, the injected `webview.js` script now rewrites any `a.internal` links to include the port number of the current websocket connection. This ensures that as the user navigates by clicking on links on the page the websocket connection to the language server is preserved. Also by doing an initial scroll sync on page load, this ensures that the editor is kept in sync with the change! There is a chance for this to be a bit flaky as this in direct conflict with the initial sync an editor might want to make if it initiates the preview of a page. By introducing a small delay on the sync made by the webview, we are relying on the editor winning the race and getting its message in first... I'm sure that will never cause an issue in the future!
Configuration menu - View commit details
-
Copy full SHA for 7f16384 - Browse repository at this point
Copy the full SHA 7f16384View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 493eaac - Browse repository at this point
Copy the full SHA 493eaacView commit details -
code: Derive CSP string from
asExternalUri
In addition to running the preview uri from the server through `vscode.env.asExternalUri` we need to make sure that the CSP for the embedded iframe is given the correct origin.
Configuration menu - View commit details
-
Copy full SHA for 3f03231 - Browse repository at this point
Copy the full SHA 3f03231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79d8eb8 - Browse repository at this point
Copy the full SHA 79d8eb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d424314 - Browse repository at this point
Copy the full SHA d424314View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0594794 - Browse repository at this point
Copy the full SHA 0594794View commit details -
sphinx-agent: Take entire websocket URL from query parameter
The injected `webview.js` script now assumes that the `ws` query parameter contains the entire URI to use when creating the websocket connection
Configuration menu - View commit details
-
Copy full SHA for 576c53f - Browse repository at this point
Copy the full SHA 576c53fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ced573 - Browse repository at this point
Copy the full SHA 4ced573View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34d4e51 - Browse repository at this point
Copy the full SHA 34d4e51View commit details -
build(deps-dev): bump ovsx from 0.9.4 to 0.9.5 in /code
Bumps [ovsx](https://github.com/eclipse/openvsx/tree/HEAD/cli) from 0.9.4 to 0.9.5. - [Release notes](https://github.com/eclipse/openvsx/releases) - [Changelog](https://github.com/eclipse/openvsx/blob/master/cli/CHANGELOG.md) - [Commits](https://github.com/eclipse/openvsx/commits/v0.9.5/cli) --- updated-dependencies: - dependency-name: ovsx dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 33a8865 - Browse repository at this point
Copy the full SHA 33a8865View commit details -
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.9](astral-sh/ruff-pre-commit@v0.6.5...v0.6.9)
Configuration menu - View commit details
-
Copy full SHA for 1880f9d - Browse repository at this point
Copy the full SHA 1880f9dView commit details -
build(deps-dev): bump esbuild from 0.23.1 to 0.24.0 in /code
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.23.1 to 0.24.0. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.23.1...v0.24.0) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 33bf8ba - Browse repository at this point
Copy the full SHA 33bf8baView commit details
Commits on Oct 13, 2024
-
build(deps-dev): bump @vscode/vsce from 3.1.0 to 3.1.1 in /code
Bumps [@vscode/vsce](https://github.com/Microsoft/vsce) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/Microsoft/vsce/releases) - [Commits](microsoft/vscode-vsce@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: "@vscode/vsce" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for db519b0 - Browse repository at this point
Copy the full SHA db519b0View commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3d88524 - Browse repository at this point
Copy the full SHA 3d88524View commit details -
sphinx-agent: Suppress and report extension errors
The sphinx-agent will no longer crash if the configured environment is missing an extension. Instead the error is suppressed and the agent will attempt to report it to the user as a diagnostic However, the diagnostic will only work if the extensions are declared in `conf.py` using the "standard" Sphinx format i.e. ```python extensions = [ 'a', 'b', ... ] ```
Configuration menu - View commit details
-
Copy full SHA for 179730c - Browse repository at this point
Copy the full SHA 179730cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eca2086 - Browse repository at this point
Copy the full SHA eca2086View commit details
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d6462b2 - Browse repository at this point
Copy the full SHA d6462b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aff08eb - Browse repository at this point
Copy the full SHA aff08ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07121fc - Browse repository at this point
Copy the full SHA 07121fcView commit details -
lsp: Use fallback env when possible
If a client provides the `esbonio.sphinx.fallbackEnv`, repurpose the server's Python interpreter to launch the Sphinx agent.
Configuration menu - View commit details
-
Copy full SHA for 4e1ca8b - Browse repository at this point
Copy the full SHA 4e1ca8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0755c5 - Browse repository at this point
Copy the full SHA a0755c5View commit details -
Most runs conclude on the order 5min +/- 2min, so if we hit the 20min mark chances are something has hung.
Configuration menu - View commit details
-
Copy full SHA for d9466d7 - Browse repository at this point
Copy the full SHA d9466d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6701fe2 - Browse repository at this point
Copy the full SHA 6701fe2View commit details -
sphinx-agent: Expose the AST for
conf.py
via an attributeThis allows us to parse the file once in a central location
Configuration menu - View commit details
-
Copy full SHA for c2c90bd - Browse repository at this point
Copy the full SHA c2c90bdView commit details -
sphinx-agent: Implement a fallback html_theme
The sphinx agent can now handle the case where the requested `html_theme` is not available in the environment by suppressing the raised error, overriding the value of `html_theme` and attempting to run `Sphinx.__init__` again.
Configuration menu - View commit details
-
Copy full SHA for 591748e - Browse repository at this point
Copy the full SHA 591748eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d98957 - Browse repository at this point
Copy the full SHA 7d98957View commit details