Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "maxDuration" documentation as the prop is removed from "<Suspense>" #22

Closed
dance2die opened this issue Jul 12, 2019 · 3 comments
Closed

Deprecate "maxDuration" documentation as the prop is removed from "<Suspense>" #22

dance2die opened this issue Jul 12, 2019 · 3 comments

Comments

@dance2die
Copy link
Contributor

dance2die commented Jul 12, 2019 •
edited
Loading

maxDuration has been removed on 2 Apr 2019.

References:

  1. Removed from React: Remove maxDuration facebook/react#15272
  2. Removed from Flow: React React.Suspense maxDuration attribute facebook/flow#7613
@swyxio
Copy link
Owner

swyxio commented Jul 12, 2019

pr?

@dance2die
Copy link
Contributor Author

dance2die commented Jul 12, 2019 •
edited
Loading

I will do it after work.

@dance2die dance2die mentioned this issue Jul 13, 2019
Merged
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Added an update for 'maxDuration' removal from Suspense and changed t…
fc202ec 
…he date format to DD MMM YYYY to conform with the TimeLine dates. swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Huge Update - Removed documentation on 'maxDuration' swyxio#22
424acd3
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Created a new list item for React.Suspense maxDuration for Flow attri…
51b755f 
…bute swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Moved maxDuration updates from 'Code To Check Out' to 'Concurrent Rea…
e265f6f 
…ct/React Fiber general info' section swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Updated hard-coded 150ms maxDuration timeout value with Just Noticeab…
cf732e6 
…le Difference hueristic as reviewed by @arianon swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Added 'Just Noticeable Difference' hueristic for React.Suspense maxDu…
a344efe 
…ration replacement in Timeline swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Removed 'maxDuration is NOT actual Duration' section as per @swyx on h…
6a8f9ea 
…ttps://github.com/sw-yx/fresh-concurrent-react/pull/23/files#r303214200 swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
@dance2die
Removed 'maxDuration is NOT actual Duration' section as per @sw-yx on h…
c15960a 
…ttps://github.com/sw-yx/fresh-concurrent-react/pull/23/files#r303214200 swyxio#22
swyxio added a commit that referenced this issue Jul 14, 2019
@swyxio
Deprecate "maxDuration" documentation as the prop is removed from… (#23)
28ffa7a 
Deprecate "maxDuration" documentation as the prop is removed from "<Suspense>" #22
NAKKA-K pushed a commit to bookbok/old-bookbok that referenced this issue Jun 9, 2020
React.SuspenseのmaxDurationがdepulicated swyxio/brain#22
7bffcde
@Dema
Copy link

Dema commented Dec 2, 2020

Is it possible to revert this change and restore maxDuration until you come up with better heuristics?. Because 150ms is too small and when we use lazy loading of React components we get the flickering of the loading indicators, just what we wanted to avoid by introducing Suspense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dema @swyxio @dance2die