-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use sveltejs/adapter-auto #100
Conversation
sounds good. i have my own skepticism of adapter-auto, as it means we are constrained to using lowest-common-denominator features of all 3 platforms. but not backed by any research. |
@sw-yx I am not sure, but it seems I haven't tried, but as per the adapter-netlify readme it seems this should be possible.
|
yeah so the question is what exactly are the netlify specific options, and when do we want to use them for example the edge rendering looks really good. not sure how adapter-auto works with vercel/cloudflare offerings |
@sw-yx I think everything you set as adapter options are the platform specific options. To emable edge in verdel you do following: import adapter from '@sveltejs/adapter-vercel';
/** @type {import('@sveltejs/kit').Config} */
const config = {
kit: {
adapter: adapter({ edge: true }),
}
}; for netlify it’s: import adapter from '@sveltejs/adapter-netlify';
/** @type {import('@sveltejs/kit').Config} */
const config = {
kit: {
adapter: adapter({ edge: true }),
}
}; I am not sure if setting the For now we are not using any platform specific options so it is safe to use |
ok lets see how it goes - is this PR still in draft or is it good to go? |
this works so sticking with this for now but i have reported the issue in sveltejs/kit#6592 |
Switched
@sveltejs/adapter-netlify
to@sveltejs/adapter-auto
Will close #74
Working deployments: